-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context fragment of contained single entity #2009
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, only one comment
odata-protocol/10 Context URL.md
Outdated
@@ -103,6 +103,7 @@ the type of the returned entity collection. | |||
Context URL template: | |||
|
|||
{context-url}#{entity-set}/$entity | |||
{context-url}#{single-navprop} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 25 above we define
{entity-set}
is the name of an entity set or path to a containment navigation property
Please call this {single-entity}
, add a definition for it, use it also for singletons, and reduce the definition of {entity-set}
to collection-valued nav props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think that the text will be easier if we define
{entity-set}
is the name of an entity set or path to a collection-valued containment navigation property{single-entity}
is the name of a singleton or path to a single-valued containment navigation property
and then use these definitions in the text below
odata-protocol/10 Context URL.md
Outdated
@@ -103,6 +103,7 @@ the type of the returned entity collection. | |||
Context URL template: | |||
|
|||
{context-url}#{entity-set}/$entity | |||
{context-url}#{single-navprop} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{context-url}#{single-navprop} | |
{context-url}#{single-entity} |
Use this also for singletons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so far. Only nit is that {singleton}
also appears in
- section 10.8 Projected Entity
- section 10.10 Expanded Entity
and should be replaced with {single-entity}
If the response is not a subset of a | ||
single entity set, the `{select-list}` is instead appended to the | ||
`{type-name}` of the returned entity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case cannot occur, because the response in this section is always one entity, not a (sub)set.
navigation properties
2000/single-navprop-context
Fixes #2000