Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add automated release workflow #44

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 8, 2020

No description provided.

@kostko kostko force-pushed the kostko/feature/release branch 7 times, most recently from a2d471b to 0772471 Compare October 8, 2020 11:35
@kostko kostko marked this pull request as ready for review October 8, 2020 11:36
@kostko kostko requested review from ptrus and tjanez October 8, 2020 11:37
# Pattern that roughly matches Ledger JS' version tags.
# For more details on GitHub Actions' pattern match syntax, see:
# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags.
- 'v[0-9]+.[0-9]+*'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a short note about the release process in the readme would be useful: e.g. "to publish a new version of the package bump the version and push a v<version> tag."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a simple release process doc, we'll improve it once we finish #12.

@kostko kostko force-pushed the kostko/feature/release branch 3 times, most recently from 26d0ab2 to 04df925 Compare October 8, 2020 12:26
@kostko kostko mentioned this pull request Oct 8, 2020
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.github/workflows/release.yml Show resolved Hide resolved
@kostko kostko merged commit 5132130 into master Oct 8, 2020
@kostko kostko deleted the kostko/feature/release branch October 8, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants