Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update several xrefs and syntax issues #9

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Nov 13, 2024

This PR solves several logical and syntactic issues with references being encoded improperly

addresses most of #7

sibo-edit.obo Outdated
relationship: part_of SIBO:0000113 ! gaster

[Term]
id: SIBO:0000142
name: presclerite
def: "Presclerite- A distinctly differentiated anterior section of an abdominal sclerite, separated from the remainder of the sclerite by a ridge, constriction, or both. In the ant abdomen it is usual for the posterior portion of each sclerite to overlap the anterior portion of the following segment. The overlapped area usually lacks sculpture and pilosity, but the absence of these features alone does not constitute a presclerite. Presclerite derived from tergites are termed pretergites, those from sternites, presternites. The remainder of each sclerite, posterior to these developments, is the postsclerite and may be termed posttergite and poststernite, respectively. The presclerites of abdominal segment 3 form a very specialized articulateio with the posterior end of abdominal segment 2, termed the helicum." [XX:<new dbxref> "Bolton, B. (1994). Identificstion guide to the ant genera of the world. Cambridge, Mass., Harvard University PRess. pp.1-222."]
def: "Presclerite- A distinctly differentiated anterior section of an abdominal sclerite, separated from the remainder of the sclerite by a ridge, constriction, or both. In the ant abdomen it is usual for the posterior portion of each sclerite to overlap the anterior portion of the following segment. The overlapped area usually lacks sculpture and pilosity, but the absence of these features alone does not constitute a presclerite. Presclerite derived from tergites are termed pretergites, those from sternites, presternites. The remainder of each sclerite, posterior to these developments, is the postsclerite and may be termed posttergite and poststernite, respectively. The presclerites of abdominal segment 3 form a very specialized articulateio with the posterior end of abdominal segment 2, termed the helicum." ["Bolton, B. (1994). Identificstion guide to the ant genera of the world. Cambridge, Mass., Harvard University PRess. pp.1-222."]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left the bibliographic reference - wont that alone create a wrong xref?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was editing this in browser and might have missed a few corner cases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a major revision, check it

@cthoyt cthoyt marked this pull request as draft November 13, 2024 13:59
A lot of edits happened here. @cthoyt, I normalised natural language bibliographic references as part of the definition string, and fixed a few syntactic errors.
Lots of diff, but they all come from the latest edit to the edit file
@cthoyt cthoyt changed the title Remove dummy xrefs Update several xrefs and syntax issues Nov 13, 2024
sibo-edit.obo Outdated Show resolved Hide resolved
@cthoyt cthoyt marked this pull request as ready for review November 13, 2024 14:36
@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 13, 2024

thanks @matentzn. LGTM

@matentzn matentzn merged commit 488fe46 into obophenotype:master Nov 13, 2024
@cthoyt cthoyt deleted the patch-1 branch November 13, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants