feat: Update to v2 #1907
Open
feat: Update to v2 #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
force-pushed
the
feat/updater-2.0
branch
from
04cc913
to
766d19b
Compare
dpaasman00
commented
Oct 9, 2024
BinaryFissionGames
suggested changes
Oct 24, 2024
updater/internal/install/install.go
Outdated
Comment on lines
404
to
416
| // Retrieve agent id and convert to UUID | ||
| agentID, ok := manager["agent_id"].(string) | ||
| if !ok { | ||
| return fmt.Errorf("read in agent id") | ||
| } | ||
| agentULID, err := ulid.Parse(agentID) | ||
| if err != nil { | ||
| return fmt.Errorf("parse agent id into a ULID: %w", err) | ||
| } | ||
| ulidBytes, err := agentULID.MarshalBinary() | ||
| if err != nil { | ||
| return fmt.Errorf("marshal ulid to bytes: %w", err) | ||
| } |
There was a problem hiding this comment.
With #1907 merged, we'll want to check if it's a UUID as well.
Side note, it does suck a bit that this will cause the agent to report itself with a new ID. I don't think there's a way around it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Reworks updater to update an installation from v1 to v2.
endpoint,secret_key, andagent_idvalues from existing manager.yaml and uses them to create basic supervisor.yamlTest following this guide: https://docs.google.com/document/d/1ZaSXnJIu-rjctiihBdBLvHymuaB7GFIW8I56biN5v8Q/edit?tab=t.0
Checklist