Add observable-builder user and use /project #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an observable-builder user with a home directory of /project. This uses 8000 as the uid since that's not likely to collide with any users on the container runtime host machines.
|
Working on fixing the breakages. I just have to order the creation of the user correctly |
mythmon
requested changes
Sep 17, 2024
* Use a traditional /home directory * Combine poetry into python layer * Rename mounts * Removed unused imports * Put tar-fs into devDependencies
mythmon
approved these changes
Sep 19, 2024
|
@jessedearing unfortunately it looks like this would break cloud builds, at least in my local testing. The files the builder copies into the image are owned by uid 1000. Do you think we can fix this quickly, or should we roll this bac until we can figure out a way to make it compatible? |
|
We can change the uid to 1000 which should work. Will follow up with another PR |
Closed
|
I think it might have just been 1000 because that is my UID. I don't know what UID the builder will be using. I think maybe the right choice would be to have the builder explicitly specify a UID when copying files. Either way we should make sure to test this in-site in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an observable-builder user with a home directory of /project. This uses 8000 as the uid since that's not likely to collide with any users on the container runtime host machines.
This PR also changes the tests to use a directory copy instead of a bind mount because of something with the way GitHub actions and SELinux works. Copying the files into the container before starting it will set the file system permissions correctly. A bind mount works just fine on my load build and test so it seems like an exclusive issue to GHA.