-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add food example #1548
Open
pamacha
wants to merge
19
commits into
main
Choose a base branch
from
pamacha/food-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add food example #1548
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
dffb779
Add food example
fd6a8e8
Added components, grid layout
pstuffa db0ae53
WIP: First pass at moving Marimekko to a component
24af552
Add reactive input, refactor, and clean up
b83bbf8
Ensure colors stay consistent in area chart and mekko is wrapped in a…
14b93ec
Stabilize country colors and begin figuring out labels
bd9bb0e
Add labels to area chart
a6758ce
Add color optionality and reorganize code
1f7bb29
Grid reorg and initial color schemes
bdca398
Finesse colors, add copy, change selector
0cda8ea
small things
pstuffa 74a5e82
copy
Fil 57b9f52
review & pairing session
Fil 181fb90
placeholder in README
Fil 3c85304
revamp sorting for marimekko and sunburst and maintain steady element…
24f72c5
Sort area chart to match marimekko and update color scheme
8f7e461
Update food imports read.me
504a409
Fix area chart to 16 ribbons, delete colors JSON, and update read.me
a42f290
Add copy to help convey the stories of each chart
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d3.sort accepts an accessor, which is often simpler than using a comparator. You can inline this in L74.