Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python literals via pyodide #293

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

python literals via pyodide #293

wants to merge 6 commits into from

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jun 23, 2022

This is roughly the same approach as taken by Grant Nestor, although I made some changes to fix falsey value interpolation and to adopt the recommended/public APIs such as runPythonAsync instead of calling eval_code_async directly.

@mbostock mbostock requested a review from duaneatat June 23, 2022 14:07
Copy link
Contributor

@duaneatat duaneatat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool!

@mootari
Copy link
Member

mootari commented Jun 23, 2022

Should the pyodide instance be exposed so that you can e.g. load micropip?

* patch matplotlib’s show

* font-awesome for matplotlib buttons

* fix for redrawing figure

* only remove if parent is body
@mbostock
Copy link
Member Author

Should the pyodide instance be exposed so that you can e.g. load micropip?

I’m not going to do this yet, but we might add this in the future.

@mbostock mbostock marked this pull request as draft July 4, 2022 12:34
@mbostock
Copy link
Member Author

mbostock commented Jul 4, 2022

Putting this on hold as, at a minimum, I think we need to update the Observable Inspector to do a better job with PyProxy objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants