-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook Downloads (Standard Library Changes) #43
Conversation
jashkenas
commented
May 11, 2018
- Creates UMD and ES Module bundles of the standard library.
@mbostock — if approved, I'd like to merge and publish this PR as version 1.0.0 on npm... |
Per https://github.com/tc39/proposal-observable, |
My other concern #31 #32 is whether we should formally deprecate (though still support) the following methods:
That said I’d probably not deprecate:
I find myself still using DOM.svg a lot because it sets the viewBox automatically, likewise DOM.context2d is useful for its automatic high DPI support, and might as well keep DOM.canvas for symmetry with DOM.svg and for WebGL. In practice this would mean moving the documentation for the deprecated methods from README.md to a DEPRECATED.md, and perhaps adding these to the deprecated list for autocomplete. |
CSS and UMD namespaces updated across the board to (Although, I still hold out hope that one day we'll be able to purchase observable.com)... Just for expediency's sake: If we're not changing any of the functionality (yet), just the documentation, I don't think we need to make a decision on the deprecations before merging this branch and publishing a 1.0.0 — as long as the functionality remains in place, we can deprecate at any point afterwards. |
Okay, that’s fair; we can punt on deprecation. 👍 |
Alright, @tmcw — if you don't mind taking a look at this, I'd like to merge this, and publish stdlib 1.0.0 to npm ... once notebook-runtime PR has been merged as well. |