Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: Remove checkAudioBuffering #165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prgmitchell
Copy link
Contributor

@prgmitchell prgmitchell commented Jun 9, 2024

Description

This removes the checkAudioBuffering function from the log analyzer.

Motivation and Context

In all of my time in support, apart from the application audio capture buffering issues which have been solved, this has rarely contributed to the interaction and almost always detracts from it. Nearly every instance of this error relates to sources that are not actually using audio or sources that hit max audio buffering, reset, and then had no issues all without the user noticing. Most see this critical error and assume it is the cause of their unrelated issue. This usually leads to a conversation explaining that if a user is not actually experiencing any audio issues you would expect (cutting out or audio going totally silent), this can simply be ignored anyways.

How Has This Been Tested?

Still works fine, nothing else depends on this function.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@mihawk90
Copy link
Contributor

There's a typo on the Commit and PR heading, a missing i

@prgmitchell prgmitchell changed the title audio: Remove checkAudoBuffering audio: Remove checkAudioBuffering Sep 10, 2024
Removes the audio buffering check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants