Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OCaml 5.3 effect syntax #2562

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Zeta611
Copy link

@Zeta611 Zeta611 commented Jun 26, 2024

As mentioned in #2559, this provides a support for OCaml 5.3 effect syntax.

Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extremely slow reply. We've been focusing on the 5.2 syntax support and couldn't allocate a lot of time to the rest.
I've fixed the conflicts in Ast.ml and added a test. Let's merge if the CI doesn't catch any bugs.

Huge thanks for your contribution :)

@Zeta611
Copy link
Author

Zeta611 commented Nov 4, 2024

No problem! :)

I see few tests have been failed due to build error---is it something to be worried about?

@Julow
Copy link
Collaborator

Julow commented Nov 4, 2024

The CI is failing when testing on a larger corpus of code with errors like this:

File "code/infer/infer/src/integration/IssuesTest.ml", line 17, characters 50-56:
17 |   Option.iter taint_policy_privacy_effect ~f:(fun effect ->
                                                       ^^^^^^
Error: Syntax error
File "code/irmin/src/irmin/node_intf.ml", line 127, characters 7-13:
127 |   type effect := expected_depth:int -> node_key -> t option
             ^^^^^^
Error: Syntax error

5.3 also have a mechanism for disabling keywords in the lexer, that would have to be backported first. I'll work on backporting this and making it work with the ocaml-version that ocamlformat has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants