Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm Packages #347

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Update npm Packages #347

merged 12 commits into from
Oct 5, 2023

Conversation

ben9583
Copy link
Member

@ben9583 ben9583 commented Sep 28, 2023

Updates some very old npm packages and resolves any conflicts with major version changes.

Specifically, the react-keycloak package is no longer maintained, so I've switched over to oidc-client-ts as recommended in the deprecation announcement. I've also upgrade the yarn version and added some new Gatsby plugins that are required to get emotion working with Gatsby v5.

@ocfjenkins
Copy link

ocfjenkins bot commented Sep 30, 2023

View the preview deployment of this pull request here: https://PR-347.new.ocf.berkeley.edu

@ocfjenkins
Copy link

ocfjenkins bot commented Oct 5, 2023

View the preview deployment of this pull request here: https://PR-347.new.ocf.berkeley.edu

1 similar comment
@ocfjenkins
Copy link

ocfjenkins bot commented Oct 5, 2023

View the preview deployment of this pull request here: https://PR-347.new.ocf.berkeley.edu

@ben9583
Copy link
Member Author

ben9583 commented Oct 5, 2023

^ log in doesn't work because redirect_uri (PR-347.*) is not on the approved list for the client_id "ocfstatic". It should work on main or localhost:8000.

@ben9583 ben9583 requested a review from Kalissaac October 5, 2023 03:14
Copy link
Member

@Kalissaac Kalissaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only comment is that we also have a new keycloak instance at idm.ocf.berkeley.edu but i don't have access to it yet unfortunately so i can't set it up for this

@ben9583
Copy link
Member Author

ben9583 commented Oct 5, 2023

lgtm, only comment is that we also have a new keycloak instance at idm.ocf.berkeley.edu but i don't have access to it yet unfortunately so i can't set it up for this

Thanks! Yea I heard about that but I think it should be an easy switchover. We can get that in a new PR once that's ready.

@ben9583 ben9583 merged commit f251ecd into master Oct 5, 2023
1 check passed
@ben9583 ben9583 deleted the npm-updates branch October 5, 2023 03:27
@ben9583 ben9583 mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants