Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some linting to CI #53

Open
oconnor663 opened this issue Oct 18, 2017 · 1 comment
Open

add some linting to CI #53

oconnor663 opened this issue Oct 18, 2017 · 1 comment

Comments

@oconnor663
Copy link
Owner

@TalhaKhatri fixed a bunch of Clippy warnings in #52. It would be nice to get something into Travis to make sure we don't regress these fixes over time.

One thing to think about: I get the impression that Clippy adds new lints all the time. That could mean that our code "breaks" without actually changing, just because Clippy started checking something new. Maybe the standard way to deal with this is to pin a specific version of Clippy? I haven't looked into it yet.

@BrainMaestro
Copy link
Contributor

Clippy adds new lints, but usually they don't make new lints errors unless for a very good reason. See the categories. I think the default might be okay, and just customize if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants