Minor codestyle fixes #52
Conversation
|
Ha, I looked at those lints a couple weeks ago, but I think it was just too late in the evening and I didn't have the energy for dealing with it :) I'll go ahead and merge this when CI passes. Thanks for fixing! What do you think we should do as far as integrating Clippy into CI? There's probably some easy way to get Travis to run it? |
| @@ -1804,8 +1804,7 @@ impl WaitMode { | |||
| // guaranteed to finish soon). Blocking waits should always join, even | |||
| // in the presence of errors. | |||
| match (self, expression_result) { | |||
| (&WaitMode::Blocking, _) => true, | |||
| (_, &Ok(Some(_))) => true, | |||
| (&WaitMode::Blocking, _) | (_, &Ok(Some(_))) => true, | |||
| _ => false, | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Musing unrelated to this fix:
This while should_join_background_thread concept feels really complicated now that I'm getting back to it :( I've been planning to get rid of the Then concept entirely, because of the complications like this that it creates, and it might be that then I can delete this whole thing...
|
The OSX builds seem blocked for some reason. Hopefully they'll kick off overnight. |
2 similar comments
|
Looks like all the checks have passed. This was actually my first opensource PR! 🎉 I'll have to look into the integration of Clippy in to CI. If I find something, I'll let you know. |
|
Congrats! And thanks for figuring it all out. I just filed #53 for thinking about the CI side of things -- feel free to throw in thoughts there. |
These are just some minor adjustments that don't change the logic of the library.
Mostly guided by clippy.