Setup role to initialize openshift-tests-private repo #30
Conversation
ppc64le-cloud-bot
added
the
size/L
AdityaHonkalas
changed the title
AdityaHonkalas
force-pushed
the
init-setup-role
branch
3 times, most recently
from
b6be0a8
to
45b29df
Compare
AdityaHonkalas
force-pushed
the
init-setup-role
branch
from
45b29df
to
e857ecd
Compare
AdityaHonkalas
changed the title
| | golang_install_tarball | no | `https://go.dev/dl/go1.19.4.linux-ppc64le.tar.gz` | Golang tarball for `ppc64le` arch with version `>= 1.18`, the default is given for version `1.19.4`. | | ||
| | openshift_tests_private_basedir | no | `~/ocp-validation` | Base directory path to clone the `openshift-tests-private` repo. It will get created if path not exists or not provided. | | ||
| | openshift_tests_private_clone_url | no | `https://github.com/openshift/openshift-tests-private` | Git clone URL, the default has been set for `openshift-tests-private` repository. | | ||
| | openshift_tests_private_branch | no | master | Git branch name, the default branch name has been set as `master`. | |
There was a problem hiding this comment.
nit: no need to say "the default is...." in the comments as it is already provided in Default column.
| when: github_username == "" or github_personal_access_token == "" | ||
|
|
||
| - name: Install the development tools | ||
| yum: |
There was a problem hiding this comment.
Is'nt it better to use dnf instead? @pravin-dsilva
Signed-off-by: Aditya Honkalas <[email protected]>
AdityaHonkalas
force-pushed
the
init-setup-role
branch
from
e857ecd
to
da45b49
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AdityaHonkalas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@AdityaHonkalas sorry for keeping this PR for long... could you please rebase and validate if this code is still ok to merge? |
Signed-off-by: Aditya Honkalas [email protected]