Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement and bug fix in ocp-descheduler role #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enhancement and bug fix in ocp-descheduler role #36

wants to merge 1 commit into from

Conversation

AdityaHonkalas
Copy link
Contributor

Signed-off-by: Aditya Honkalas [email protected]

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2023
@yussufsh
Copy link
Contributor

yussufsh commented Jan 14, 2023 •
edited
Loading

Check #37 if you need similar in this role. Otherwise.....
/lgtm

yussufsh
yussufsh previously approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2023
@yussufsh
Copy link
Contributor

/hold

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2023
@AdityaHonkalas
Copy link
Contributor Author

Hello @yussufsh, some other operator roles has the similar cleanup process. Creating a common role for operator resource cleanup for roles that requires operator cleanup.

@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@ppc64le-cloud-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@AdityaHonkalas AdityaHonkalas changed the title Added operator cleanup task to ocp-descheduler role Enhancement and bug fix in ocp-descheduler role Jan 20, 2023
@AdityaHonkalas
Copy link
Contributor Author

Hello @yussufsh and @pravin-dsilva , I have been pushed the new changes in playbooks/roles/ocp-descheduler role, this changes contains operator resource cleanup and bug fix along with the refactorization in the playbooks/roles/ocp-descheduler/tasks/main.yml .

@AdityaHonkalas
Copy link
Contributor Author

Hello @pravin-dsilva, @yussufsh ! Please provide your comments on the last commit changes to the PR, thanks !!

yussufsh
yussufsh approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdityaHonkalas, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh
Copy link
Contributor

@pravin-dsilva FYA

@yussufsh
Copy link
Contributor

Is this change still valid? @AdityaHonkalas @pravin-dsilva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@pravin-dsilva pravin-dsilva Awaiting requested review from pravin-dsilva

Requested changes must be addressed to merge this pull request.

Assignees

@yussufsh yussufsh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdityaHonkalas @yussufsh @ppc64le-cloud-bot @pravin-dsilva