Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.lua #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update api.lua #6

wants to merge 1 commit into from

Conversation

git512
Copy link

@git512 git512 commented Jul 15, 2018

Require server privs to access digicomputer until sandboxing in place.

Require server privs to access digicomputer until sandboxing in place.
@git512
Copy link
Author

git512 commented Jul 15, 2018

Change to only allow those with "server" privs to access digicomputers to keep normal players from accessing or modifying authentication files. Only needed until it can be further sandboxed.

@octacian
Copy link
Owner

Hmmm. This isn't a bad idea. Right now it is possible for computers to break out of the filesystem, which is seriously problematic. It would be better, though, to register a computer privilege or something similar in the module's init.lua though, as the server privilege is very general.

Could you also make your commit message more descriptive and separate the if statements into multiple lines?

An example commit message that might be better:

Require computer privilege to use computers

A short description explaining why could also be good too.

On on unrelated note, I've lately been considering creating an abstract filesystem of sorts based off of node meta, not sure though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants