Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some style and change some code #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some style and change some code #9

wants to merge 1 commit into from

Conversation

lanzhiheng
Copy link

  1. add some background color and text style for this library.
  2. change $: to $LOAD_PATH, I think that is more semantization.

@lanzhiheng
Add some style and change some code
cdc71b9 
1. add some background color and text style for this library.
2. change `$:` to `$LOAD_PATH`, I think that is more semantization.
ccmywish
ccmywish approved these changes May 9, 2023
View reviewed changes
Copy link

@ccmywish ccmywish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is good, because it added missing features like background colors and text styles.

Could you please review it? @parkr @imathis

Hope to see it merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccmywish ccmywish ccmywish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanzhiheng @ccmywish