CI: change node to v20 and fix docker run

oddsteam · Mar 31, 2024 · a4382c0 · a4382c0
1 parent 69d90f6
commit a4382c0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/ci.dev.yml b/.github/workflows/ci.dev.yml
@@ -79,4 +79,6 @@ jobs:
             echo "$DOCKER_IMAGE_WITH_TAG"
             aws ecr get-login-password --region ap-southeast-1 | docker login --username AWS --password-stdin 844772501268.dkr.ecr.ap-southeast-1.amazonaws.com
             docker pull $DOCKER_IMAGE_WITH_TAG
-            docker run -p 3001:3001 $DOCKER_IMAGE_WITH_TAG
+            docker stop training-api
+            docker rm training-api
+            docker run -p 3001:3001 --name training-api -d $DOCKER_IMAGE_WITH_TAG
diff --git a/Dockerfile b/Dockerfile
@@ -1,5 +1,5 @@
 # Use the official Node.js image as a base
-FROM node:16
+FROM node:20
 
 # Set the working directory inside the container
 WORKDIR /app