Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Timezone Support to Odin #4335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add Timezone Support to Odin #4335

wants to merge 6 commits into from

Conversation

colrdavidson
Copy link
Member

No description provided.

flysand7
flysand7 reviewed Oct 1, 2024
View reviewed changes
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
@colrdavidson colrdavidson marked this pull request as ready for review October 4, 2024 23:11
@colrdavidson
Copy link
Member Author

If you're running an odd linux / bsd build, please give this one a fair shake.
I suspect we'll have to special-case timezone-folder and local timezone paths here and there.

gingerBill
gingerBill reviewed Oct 6, 2024
View reviewed changes
core/time/datetime/constants.odin
records: []TZ_Record,
shortnames: []string,
}

/*
A type representing datetime.
*/
DateTime :: struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR but we should probably rename this to Date_Time

laytan
laytan reviewed Oct 8, 2024
View reviewed changes
Copy link
Sponsor Collaborator

@laytan laytan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general there is no handling of allocation errors anywhere, not sure if that's fine or not, up to Bill probably.

core/time/datetime/constants.odin Show resolved Hide resolved
core/time/timezone/tz_unix.odin Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tzif.odin Show resolved Hide resolved
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
core/time/timezone/tzif.odin Outdated Show resolved Hide resolved
laytan
laytan reviewed Oct 10, 2024
View reviewed changes
core/time/datetime/constants.odin Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tz_unix.odin Outdated Show resolved Hide resolved
core/time/timezone/tz_unix.odin Show resolved Hide resolved
core/time/timezone/tzdate.odin Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelimion Kelimion Kelimion left review comments

@gingerBill gingerBill gingerBill left review comments

@laytan laytan laytan left review comments

@flysand7 flysand7 flysand7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@colrdavidson @Kelimion @gingerBill @laytan @flysand7