Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #17

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Bug fixes #17

merged 4 commits into from
Aug 29, 2023

Conversation

tadeubas
Copy link

  • Test mnemonic checksum before asking for passphrase
  • Avoid double Exception when one is already raised at load wallet output descriptor
  • Changed the derivation path on screen to use apostrophe, following the majority of wallets (now shows: m/84'/0'/0'/0 instead of m/84h/0h/0h/0)

@codecov-commenter
Copy link

Codecov Report

Merging #17 (37b620b) into develop_rc (c1405fb) will increase coverage by 0.00%.
Report is 2 commits behind head on develop_rc.
The diff coverage is 70.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop_rc      #17   +/-   ##
===========================================
  Coverage       92.02%   92.02%           
===========================================
  Files              42       42           
  Lines            5264     5268    +4     
===========================================
+ Hits             4844     4848    +4     
  Misses            420      420           
Files Changed Coverage Δ
src/krux/pages/home.py 85.99% <25.00%> (-0.05%) ⬇️
src/krux/key.py 96.15% <100.00%> (+0.32%) ⬆️
src/krux/pages/login.py 90.78% <100.00%> (+0.02%) ⬆️

@odudex odudex merged commit 87d89bc into odudex:develop_rc Aug 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants