Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted: font constant names, font range conditions #43

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

jdlcdl
Copy link

@jdlcdl jdlcdl commented Aug 28, 2024

Description

Adjustments for pr_446:

  • inclusive codepoint range checks for chinese range, then korean range, maybe more in the future?
  • constant naming conventions inherited from odudex's MaixPy support for asian langs.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (wonder_mv@9052956). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             wonder_mv      #43   +/-   ##
============================================
  Coverage             ?   93.33%           
============================================
  Files                ?       60           
  Lines                ?     7422           
  Branches             ?        0           
============================================
  Hits                 ?     6927           
  Misses               ?      495           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex
Copy link
Owner

odudex commented Aug 28, 2024

Thank you Jean!

@odudex odudex merged commit 93e81c5 into odudex:wonder_mv Aug 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants