Skip to content

Commit

Permalink
Introduce mean squared score for delta adjustments
Browse files Browse the repository at this point in the history
This patch introduces the value `meanSquaredScore`, which makes the
initial delta sensitive to unstable iterative deepening scores.
  • Loading branch information
Nonlinear2 authored and PikaCat-OuO committed Oct 13, 2024
1 parent f2504ba commit 73cadf0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 10 deletions.
8 changes: 6 additions & 2 deletions src/search.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ void Search::Worker::iterative_deepening() {
selDepth = 0;

// Reset aspiration window starting size
delta = 9 + std::abs(rootMoves[pvIdx].meanSquaredScore) / 34069;
Value avg = rootMoves[pvIdx].averageScore;
delta = 9 + avg * avg / 34069;
alpha = std::max(avg - delta, -VALUE_INFINITE);
beta = std::min(avg + delta, VALUE_INFINITE);

Expand Down Expand Up @@ -973,7 +973,7 @@ Value Search::Worker::search(
// (alpha, beta), then that move is singular and should be extended. To
// verify this we do a reduced search on the position excluding the ttMove
// and if the result is lower than ttValue minus a margin, then we will
// extend the ttMove. Recursive singular search is avoided.
// extend the ttMove. Recursive singular search is avoided.

// Note: the depth margin and singularBeta margin are known for having
// non-linear scaling. Their values are optimized to time controls of
Expand Down Expand Up @@ -1173,6 +1173,10 @@ Value Search::Worker::search(
rm.averageScore =
rm.averageScore != -VALUE_INFINITE ? (2 * value + rm.averageScore) / 3 : value;

rm.meanSquaredScore = rm.meanSquaredScore != -VALUE_INFINITE * VALUE_INFINITE
? (value * std::abs(value) + rm.meanSquaredScore) / 2
: value * std::abs(value);

// PV move or new best move?
if (moveCount == 1 || value > alpha)
{
Expand Down
17 changes: 9 additions & 8 deletions src/search.h
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,15 @@ struct RootMove {
return m.score != score ? m.score < score : m.previousScore < previousScore;
}

uint64_t effort = 0;
Value score = -VALUE_INFINITE;
Value previousScore = -VALUE_INFINITE;
Value averageScore = -VALUE_INFINITE;
Value uciScore = -VALUE_INFINITE;
bool scoreLowerbound = false;
bool scoreUpperbound = false;
int selDepth = 0;
uint64_t effort = 0;
Value score = -VALUE_INFINITE;
Value previousScore = -VALUE_INFINITE;
Value averageScore = -VALUE_INFINITE;
Value meanSquaredScore = -VALUE_INFINITE * VALUE_INFINITE;
Value uciScore = -VALUE_INFINITE;
bool scoreLowerbound = false;
bool scoreUpperbound = false;
int selDepth = 0;
std::vector<Move> pv;
};

Expand Down

0 comments on commit 73cadf0

Please sign in to comment.