Replace print by the Python logging framework

Log messages with level >= ERROR give an event log
message.

Also: move scheduler to a separate file scheduler.py.

server/development.ini

@@ -38,7 +38,7 @@ port = 6542
 keys = root, fishtest
 
 [handlers]
-keys = console
+keys = console, events
 
 [formatters]
 keys = generic
@@ -49,7 +49,7 @@ handlers = console
 
 [logger_fishtest]
 level = DEBUG
-handlers =
+handlers = events
 qualname = fishtest
 
 [handler_console]
@@ -58,5 +58,9 @@ args = (sys.stderr,)
 level = NOTSET
 formatter = generic
 
+[handler_events]
+class = fishtest.rundb.EventHandler
+formatter = generic
+
 [formatter_generic]
-format = %(asctime)s %(levelname)-5.5s [%(name)s][%(threadName)s] %(message)s
+format = %(levelname)-5.5s [%(name)s][%(threadName)s] %(message)s

server/fishtest/actiondb.py

@@ -1,10 +1,13 @@
+import logging
 from datetime import datetime, timezone
 
 from fishtest.schemas import action_schema
 from fishtest.util import hex_print, worker_name
 from pymongo import DESCENDING
 from vtjson import ValidationError, validate
 
+logger = logging.getLogger(__name__)
+
 
 def run_name(run):
     run_id = str(run["_id"])
@@ -219,13 +222,7 @@ def insert_action(self, **action):
         try:
             validate(action_schema, action, "action")
         except ValidationError as e:
-            message = (
-                f"Internal Error. Request {str(action)} does not validate: {str(e)}"
-            )
-            print(message, flush=True)
-            self.log_message(
-                username="fishtest.system",
-                message=message,
-            )
+            message = f"Request {str(action)} does not validate: {str(e)}"
+            logger.error(message)
             return
         self.actions.insert_one(action)

server/fishtest/api.py

@@ -1,6 +1,7 @@
 import base64
 import copy
 import io
+import logging
 import re
 from datetime import datetime, timezone
 from urllib.parse import urlparse
@@ -19,6 +20,8 @@
 from pyramid.view import exception_view_config, view_config, view_defaults
 from vtjson import ValidationError, validate
 
+logger = logging.getLogger(__name__)
+
 """
 Important note
 ==============
@@ -69,7 +72,7 @@ def handle_error(self, error, exception=HTTPBadRequest):
             )
             api = urlparse(full_url).path
             error = f"{api}: {error}"
-            print(error, flush=True)
+            logger.info(error)
             raise exception(self.add_time({"error": error}))