Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OS type detection and custom coloring for root user #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bokysan
Copy link

@bokysan bokysan commented Nov 21, 2019

This commit includes these new features:

  • A segment which displays OS type. This is especially useful
    if constantly logging into different computers with different
    systems and you need to know if you need to type apk, apt,
    dnf, or yum, for example. Enable it by setting the
    theme_display_currentos variable to yes.
  • Padlock for SSH connection. You may enable the padlock by
    setting the theme_display_ssh_keylock to yes. Padlock is
    shown only when accessing the terminal via a SSH session.
    The padlock is displayed before the hostname.
  • Split username and hostname segments. This enable each segment
    to be coloured with a different background. Set
    theme_display_split_user_hostname to yes to enable this
    feature.
  • Color root username differently. When logged in as a root
    user, background (or the color of the username) will change
    to red. New colour has been added to the theme(s) for this
    feature.

This commit includes these new features:
- *A segment which displays OS type.* This is especially useful
  if constantly logging into different computers with different
  systems and you need to know if you need to type `apk`, `apt`,
  `dnf`, or `yum`, for example. Enable it by setting the
  `theme_display_currentos` variable to `yes`.
- *Padlock for SSH connection.* You may enable the padlock by
  setting the `theme_display_ssh_keylock` to `yes`. Padlock is
  shown only when accessing the terminal via a SSH session.
  The padlock is displayed _before_ the hostname.
- *Split username and hostname segments.* This enable each segment
  to be coloured with a different background. Set
  `theme_display_split_user_hostname` to `yes` to enable this
  feature.
- *Color root username differently.* When logged in as a `root`
  user, background (or the color of the username) will change
  to red. New colour has been added to the theme(s) for this
  feature.
@bobthecow
Copy link
Member

so many changes at once! it's a lot easier to discuss them separately :)

@bokysan
Copy link
Author

bokysan commented Nov 24, 2019

Kind of started fixing and ended up with a larger patch. :)

Even so, I don't think it's a lot of code changes. If you want, we can still split it, though, into separate patches. Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants