Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ranger indicator #230

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MatejKastak
Copy link

@MatejKastak MatejKastak commented Dec 22, 2019

Hello, I am using ranger which allows you to spawn a new terminal via shortcut S. The terminal will have $RANGER_LEVEL set, and it is advantageous to see if this shell is in ranger.

This PR implements: ranger prompt indicator

There is a possibility to show current RANGER_LEVEL in prompt setting theme_display_ranger_level to yes.

  • How to handle theme and color settings?

@bobthecow
Copy link
Member

Hello me understand what spawning a shell in Ranger means :)

@MatejKastak
Copy link
Author

Hello, I am sure you have understood what spawning a shell in Ranger means. I just wanted to be helpful.

Regarding the PR, what do you suggest are the next steps? Either:

  1. There is no way this PR will be included in a codebase. In that case, I will continue using my fork. And we should close this PR.
  2. You think this is a reasonable extension of the theme and you are willing to accept the changes after maybe some conditions are met.

@bobthecow
Copy link
Member

I know how pull requests work. Part of the process is understanding the motivation behind the pull request, which I'm trying to do. Please take my questions at face value.

I have never used Ranger, and didn't find any documentation in my brief search about spawning shells, or how spawned shells interact with Ranger. Help me understand it, please :)

What does it mean to be a shell spawned from Ranger? How does it affect the environment? How is it useful to show people that their shell was spawned from Ranger? What is Ranger level? How is it useful to show people the level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants