Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bug-fixes #2405

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Two bug-fixes #2405

wants to merge 4 commits into from

Conversation

SebinSong
Copy link
Collaborator

closes #2396
closes #2404

@SebinSong SebinSong self-assigned this Oct 29, 2024
Copy link

cypress bot commented Oct 29, 2024

group-income    Run #3363

Run Properties:  status check passed Passed #3363  •  git commit e12b7ca554 ℹ️: Merge 9bbe04ae132106ca7fefd687f6c6f668051e5a26 into affa61592e03442878cea59bc60f...
Project group-income
Branch Review sebin/task/#2396-non-monetary-bug
Run status status check passed Passed #3363
Run duration 09m 00s
Commit git commit e12b7ca554 ℹ️: Merge 9bbe04ae132106ca7fefd687f6c6f668051e5a26 into affa61592e03442878cea59bc60f...
Committer Sebin Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎

Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Minor issue

@@ -6,7 +6,7 @@ modal-template(ref='modal' :a11yTitle='L("Add new members")')
.c-container
template(v-if='link')
i18n.is-title-4(tag='h3') Share this link to grant access to your group.
i18n.has-text-1(tag='p') After the onboarding period has ended, everyone will be asked to vote on whether or not a new member should be added. But for now, enjoy 60 free passes!
i18n.has-text-1(tag='p') After the onboarding period has ended, everyone will be asked to vote on whether or not a new member should be added. But for now, enjoy 150 free passes!
Copy link
Member

@taoeffect taoeffect Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this a variable so that we don't have to re-translate it next time it changes?

See issue for recommended variable value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in the text in the "Add new members" modal Member can leave contributions blank
2 participants