Write metadata using delayed that depends on writing array(s)

[joshua-gould]

If writing a dask array and compute = False, the image metadata will be written even if some of the array chunks are not written successfully. This ensures that metadata is written only after all chunks are stored. Thanks.

[joshmoore]

Thanks for the PR, @joshua-gould! Definitely agree with the goal of properly catching errors on write. 👍 There are two failures in the tests now, across a number of the jobs, related to no longer finding an image after the write, which sounds much like the metadata not being written. Did you see anything similar while preparing the change?

[joshua-gould]

Sorry, I fixed the logic to invoke persist when using dask in test_write_image_dask

[joshmoore]

(Launched the workflows)

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (9205bd7) to head (6461a20).
Report is 15 commits behind head on master.

Files with missing lines	Patch %	Lines
ome_zarr/writer.py	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   85.76%   85.70%   -0.06%     
==========================================
  Files          13       13              
  Lines        1531     1539       +8     
==========================================
+ Hits         1313     1319       +6     
- Misses        218      220       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joshmoore]

👍