Fixing code review comments.

omec-project · Jan 2, 2024 · 3fb0c43 · 3fb0c43
1 parent 3290162
commit 3fb0c43
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/context/db.go b/context/db.go
@@ -68,7 +68,7 @@ func SetupSmfCollection() {
 	}
 
 	smfCount := MongoDBLibrary.GetUniqueIdentity("smfCount")
-	logger.CtxLog.Infof("unique id - init smfCount %v", smfCount)
+	logger.CtxLog.Infof("unique id - init smfCount %d", smfCount)
 
 	// set os env
 	os.Setenv("SMF_COUNT", strconv.Itoa(int(smfCount)))
@@ -273,7 +273,7 @@ func StoreSeidContextInDB(seidUint uint64, smContext *SMContext) {
 	}
 	itemBsonA := ToBsonMSeidRef(item)
 	filter := bson.M{"seid": seid}
-	logger.CtxLog.Infof("filter : %+v", filter)
+	logger.CtxLog.Infof("filter: %+v", filter)
 
 	MongoDBLibrary.RestfulAPIPost(SeidSmContextCol, filter, itemBsonA)
 }
@@ -287,7 +287,7 @@ func StoreRefToSeidInDB(seidUint uint64, smContext *SMContext) {
 	}
 	itemBsonA := ToBsonMSeidRef(item)
 	filter := bson.M{"ref": smContext.Ref}
-	logger.CtxLog.Infof("filter : %+v", filter)
+	logger.CtxLog.Infof("filter: %+v", filter)
 
 	MongoDBLibrary.RestfulAPIPost(RefSeidCol, filter, itemBsonA)
 }
@@ -349,7 +349,7 @@ func DeleteSmContextInDBBySEID(seidUint uint64) {
 	seid := SeidConv(seidUint)
 	fmt.Println("db - delete SMContext In DB by seid")
 	filter := bson.M{"seid": seid}
-	logger.CtxLog.Infof("filter : %+v", filter)
+	logger.CtxLog.Infof("filter: %+v", filter)
 
 	result := MongoDBLibrary.RestfulAPIGetOne(SeidSmContextCol, filter)
 	if result != nil {
@@ -367,7 +367,7 @@ func DeleteSmContextInDBBySEID(seidUint uint64) {
 func DeleteSmContextInDBByRef(ref string) {
 	fmt.Println("db - delete SMContext In DB w ref")
 	filter := bson.M{"ref": ref}
-	logger.CtxLog.Infof("filter : %+v", filter)
+	logger.CtxLog.Infof("filter: %+v", filter)
 
 	MongoDBLibrary.RestfulAPIDeleteOne(SmContextDataColl, filter)
 }

diff --git a/context/db_uptunnel.go b/context/db_uptunnel.go
@@ -171,7 +171,7 @@ func ToBsonMNodeInDB(data *DataPathNodeInDB) (ret bson.M) {
 func StoreNodeInDB(nodeInDB *DataPathNodeInDB) {
 	itemBsonA := ToBsonMNodeInDB(nodeInDB)
 	filter := bson.M{"nodeIDInDB": nodeInDB.DataPathNodeUPFNodeID}
-	logger.CtxLog.Infof("filter : %+v", filter)
+	logger.CtxLog.Infof("filter: %+v", filter)
 
 	MongoDBLibrary.RestfulAPIPost(NodeInDBCol, filter, itemBsonA)
 }

diff --git a/pfcp/adapter/adapter.go b/pfcp/adapter/adapter.go
@@ -198,7 +198,7 @@ func HandlePfcpSessionEstablishmentResponse(msg *pfcpUdp.Message) {
 		}
 	}
 	smContext := smf_context.GetSMContextBySEID(SEID)
-	logger.PfcpLog.Infof("In HandlePfcpSessionEstablishmentResponse SEID %+v", SEID)
+	logger.PfcpLog.Infof("In HandlePfcpSessionEstablishmentResponse SEID %v", SEID)
 	logger.PfcpLog.Infof("In HandlePfcpSessionEstablishmentResponse smContext %+v", smContext)
 
 	//Get NodeId from Seq:NodeId Map