-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing unit tests with Go version 1.21 #180
Conversation
gatici
commented
Nov 2, 2023
•
edited
Loading
edited
- Updating go4.org/unsafe/assume-no-moving-gc to prevent panic caused by outdated version
- Correcting syntax errors in logging overall
- Fixing "runtime error: invalid memory address or nil pointer dereference" while running TestSendHeartbeatResponse unit test
- Fixing IP pool allocation tests
- Catching error in GetQosFlowIdFromQosId method
- Changing QosId in makeSampleQosData as integer
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
This PR is validated by running
|
428e285
to
43fd912
Compare
This PR is tested by building new image and deploying sdcore-bundle successfully. |
|
43fd912
to
7336b83
Compare
retest this please |
test this please |
@gatici, are the comments above from @ghislainbourgeois already resolved? or is there still something to be addressed? |
test this please |
Hi @gab-arrobo , The comments from @ghislainbourgeois are all resolved. |
Ok, then I am going to mark them as resolved and try to merge the PR later tonight (after running one manual test( |
Thank you! |
Signed-off-by: gatici <[email protected]>
a0a299c
to
2fceb1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to add \n
in the loggings? Is not the logger
taking care of adding a newline?
ok to test |
Signed-off-by: gatici <[email protected]>
2fceb1d
to
aa08b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (Tested changes with AiaB)