[SYCLomatic] Migration support for CUDA driver error APIs and cudaErrorr_enum #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejaX-Alaghari
changed the title
TejaX-Alaghari
force-pushed
the
cuErr_AnT
branch
from
393f9b0
to
f2c0cab
Compare
wenhuiNi
suggested changes
Nov 17, 2023
| @@ -84,6 +84,10 @@ ENTRY(cudaGetErrorString, cudaGetErrorString, true, NO_FLAG, P0, "Successful") | |||
| ENTRY(cudaGetLastError, cudaGetLastError, true, NO_FLAG, P0, "DPCT1010") | |||
| ENTRY(cudaPeekAtLastError, cudaPeekAtLastError, true, NO_FLAG, P0, "DPCT1026/DPCT1027") | |||
|
|
|||
| // error handling functions of driver API | |||
| ENTRY(cuGetErrorName, cuGetErrorName, true, NO_FLAG, P0, "Successful") | |||
There was a problem hiding this comment.
I think there are already cuGetErrorName and cuGetErrorString in
SYCLomatic/clang/lib/DPCT/APINames.inc
Line 1567 in f2c0cab
There was a problem hiding this comment.
Thanks for pointing that out @wenhuiNi.
TejaX-Alaghari
force-pushed
the
cuErr_AnT
branch
3 times, most recently
from
434e15d
to
c1a018b
Compare
Signed-off-by: Teja Alaghari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature]: Added support for migration of -
Signed-off-by: TejaX, Alaghari [email protected]