-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] Refine bindless image helper functions. #1763
Merged
zhimingwang36
merged 2 commits into
oneapi-src:SYCLomatic
from
tangjj11:bindless-helper-bug
May 10, 2024
Merged
[SYCLomatic] Refine bindless image helper functions. #1763
zhimingwang36
merged 2 commits into
oneapi-src:SYCLomatic
from
tangjj11:bindless-helper-bug
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjj11
force-pushed
the
bindless-helper-bug
branch
3 times, most recently
from
March 7, 2024 03:11
efd2c79
to
e310e9a
Compare
wenhuiNi
approved these changes
Mar 13, 2024
ziranzha
approved these changes
Mar 13, 2024
ziranzha
reviewed
Mar 13, 2024
ziranzha
reviewed
Mar 13, 2024
ziranzha
reviewed
Mar 13, 2024
tangjj11
force-pushed
the
bindless-helper-bug
branch
2 times, most recently
from
May 6, 2024 03:34
889157a
to
d382320
Compare
Signed-off-by: Tang, Jiajun [email protected]
tangjj11
force-pushed
the
bindless-helper-bug
branch
from
May 6, 2024 05:35
d382320
to
056f57c
Compare
tangjj11
force-pushed
the
bindless-helper-bug
branch
from
May 6, 2024 06:09
056f57c
to
d84c4d8
Compare
ziranzha
approved these changes
May 10, 2024
zhimingwang36
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ShengchenJ
pushed a commit
to ShengchenJ/SYCLomatic
that referenced
this pull request
Sep 27, 2024
…st. (oneapi-src#713) Signed-off-by: Tang, Jiajun [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tang, Jiajun [email protected]