Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTS to validate device reset ext #43

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Add CTS to validate device reset ext #43

merged 4 commits into from
Jul 4, 2024

Conversation

vishnu-khanth
Copy link
Contributor

@vishnu-khanth vishnu-khanth commented Jun 17, 2024 •
edited
Loading

Related-to: VLCLJ-2115

Signed-off-by: Vishnu Khanth [email protected]

@vishnu-khanth vishnu-khanth marked this pull request as ready for review June 17, 2024 08:11
@vishnu-khanth
Add CTS to validate device reset ext
e023d84 
Related-to: VLCLJ-2115

Signed-off-by: Vishnu Khanth <[email protected]>
joshuaranjan
joshuaranjan reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@joshuaranjan joshuaranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshwinKumarKulkarni
Could you please have a look at this PR ?

@vishnu-khanth
Add CTS to validate device reset ext
bd50669 
Related-to: VLCLJ-2115

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth
Add CTS to validate device reset ext
7157b34 
Related-to: VLCLJ-2115

Signed-off-by: Vishnu Khanth <[email protected]>
@joshuaranjan
Copy link
Contributor

@AshwinKumarKulkarni In the other device reset tests, we validate whether reset is successful by doing a few operations after the reset right?
Like in GivenWorkingDeviceHandleWhenResettingSysmanDeviceThenWorkloadExecutionAlwaysSucceedsAfterReset
Please share if you think that is necessary for these tests as well ?

@AshwinKumarKulkarni
Copy link
Contributor

@AshwinKumarKulkarni In the other device reset tests, we validate whether reset is successful by doing a few operations after the reset right? Like in GivenWorkingDeviceHandleWhenResettingSysmanDeviceThenWorkloadExecutionAlwaysSucceedsAfterReset Please share if you think that is necessary for these tests as well ?

Yes, we can add them as additional tests to test device is functional after reset.

@vishnu-khanth
Add CTS to validate device reset ext
85a2c36 
Related-to: VLCLJ-2115

Signed-off-by: Vishnu Khanth <[email protected]>
@vishnu-khanth
Copy link
Contributor Author

vishnu-khanth commented Jul 3, 2024 •
edited
Loading

@AshwinKumarKulkarni In the other device reset tests, we validate whether reset is successful by doing a few operations after the reset right? Like in GivenWorkingDeviceHandleWhenResettingSysmanDeviceThenWorkloadExecutionAlwaysSucceedsAfterReset Please share if you think that is necessary for these tests as well ?

Yes, we can add them as additional tests to test device is functional after reset.

Added as per the suggestion, working on Validation

@bellekal bellekal merged commit c99886b into oneapi-src:master Jul 4, 2024
11 checks passed
@vishnu-khanth vishnu-khanth deleted the reset_ext_cts branch July 12, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bellekal bellekal bellekal approved these changes

@joshuaranjan joshuaranjan joshuaranjan approved these changes

@AshwinKumarKulkarni AshwinKumarKulkarni Awaiting requested review from AshwinKumarKulkarni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vishnu-khanth @joshuaranjan @AshwinKumarKulkarni @bellekal