Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle maxAllocSize == total VRAM size in large buffer test #96

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

lyu
Copy link
Contributor

@lyu lyu commented Nov 5, 2024

No description provided.

Jemale
Jemale previously approved these changes Nov 5, 2024
Copy link
Contributor

@Jemale Jemale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

nrspruit
nrspruit previously approved these changes Nov 13, 2024
@nrspruit
Copy link
Contributor

windows error:

C:\project\conformance_tests\core\test_module\src\test_module.cpp(1227): error C2784: 'const _Ty &std::max(const _Ty &,const _Ty &) noexcept()': could not deduce template argument for 'const _Ty &' from 'uint64_t'
C:\Program Files (x86)\Microsoft Visual Studio\current\BuildTools\VC\Tools\MSVC\14.29.30133\include\utility(40): note: see declaration of 'std::max'
C:\project\conformance_tests\core\test_module\src\test_module.cpp(1227): error C2780: 'const _Ty &std::max(const _Ty &,const _Ty &,_Pr) noexcept()': expects 3 arguments - 2 provided
C:\Program Files (x86)\Microsoft Visual Studio\current\BuildTools\VC\Tools\MSVC\14.29.30133\include\utility(31): note: see declaration of 'std::max'

@lyu
Copy link
Contributor Author

lyu commented Nov 13, 2024

@nrspruit I've added type cast and formatted the file

@lyu lyu requested a review from nrspruit November 13, 2024 21:23
@nrspruit nrspruit merged commit 7494ca0 into oneapi-src:master Nov 13, 2024
13 checks passed
@lyu lyu deleted the max_alloc branch November 13, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants