Rename params in transform_reduce functions #1480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/rename_transform_reduce_params
branch
3 times, most recently
from
7b05caa
to
b9d0724
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/rename_transform_reduce_params
branch
8 times, most recently
from
28c6e5b
to
ec45680
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/rename_transform_reduce_params
branch
2 times, most recently
from
ede8408
to
6765825
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/rename_transform_reduce_params
branch
from
6765825
to
9b1b122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR - rename template params and function params of
transform_reducestaff to be closer to https://en.cppreference.com/w/cpp/algorithm/transform_reduce template param type names and add semantic info to template param names and function parameter names.Examples:
template parameter names
_BinaryOperation->_BinaryReduceOp_BinaryOperation1->_BinaryReduceOp_BinaryOperation2->_BinaryTransformOp_UnaryOperation->_UnaryTransformOpfunction parameter names
__binary_op->__reduce_op__binary_op1->__reduce_op__binary_op2->__reduce_op__unary_op->__transform_op