Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDPL][ranges] + hot fix for a test (experimental ranges) #1488

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

MikeDvorskiy
Copy link
Contributor

[oneDPL][ranges] + hot fix for a test (experimental ranges)

There was an ambiguity for dpl::experimental::ranges::transform and dpl::transform (using namespace dpl::experimental::ranges)

@SergeyKopienko
Copy link
Contributor

I believe we should include at the first place the header
#include "support/test_config.h"
in all tests.

@MikeDvorskiy
Copy link
Contributor Author

I believe we should include at the first place the header #include "support/test_config.h" in all tests.

I know, and not only "header"... But I would not have the huge changes in 47 files which fix nothing. Especially, when we have experimental tests for experimental API. Probably, ones will be deleted soon....

Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM. one optional comment.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeDvorskiy MikeDvorskiy merged commit 7f7d69c into main Apr 9, 2024
20 checks passed
@MikeDvorskiy MikeDvorskiy deleted the dev/mdvorski/fix_tests_exp_ranges branch April 9, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants