Common implementation of hosts backends buffer #1491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKopienko
force-pushed
the
dev/skopienko/host_buffer_impl_refacotring_V1
branch
from
bdadf3e
to
7a01a17
Compare
SergeyKopienko
force-pushed
the
dev/skopienko/host_buffer_impl_refacotring_V1
branch
from
7a01a17
to
89e2d57
Compare
SergeyKopienko
requested review from
rarutyun,
timmiesmith,
julianmi and
danhoeflinger
julianmi
approved these changes
Apr 12, 2024
added 5 commits
April 12, 2024 11:53
…ementation of hosts buffer with specified allocator (cherry picked from commit 41352c2)
…r implementation (cherry picked from commit 2709147)
…kend's buffer implementation (cherry picked from commit 06b946e)
…backend's buffer implementation (cherry picked from commit 89e2d57)
(cherry picked from commit fba801f)
SergeyKopienko
force-pushed
the
dev/skopienko/host_buffer_impl_refacotring_V1
branch
from
fba801f
to
a3e8bca
Compare
SergeyKopienko
deleted the
dev/skopienko/host_buffer_impl_refacotring_V1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR - to reduce the amount of duplicated code in our host backends implementations.
In this PR we implement and use the common implementation of host backends buffer, specialized by different memory allocators.
Previously we had three different implementations of hosts backends buffer: they were absolutely the same but have used different memory allocators.