Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system requirements section for ESIMD-based KT #1868

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Sep 20, 2024

The information is partially outdated. Additionally the set of the supported systems matches what the compiler/driver stack supports, that is why I suggest omitting it.

timmiesmith
timmiesmith previously approved these changes Sep 20, 2024
Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

Signed-off-by: Dmitriy Sobolev <[email protected]>
@dmitriy-sobolev
Copy link
Contributor Author

LGTM. Thank you.

Sorry to dismiss your approval. I've corrected a minor typo and moved the note at the end of a paragraph for better flow.

@timmiesmith timmiesmith self-requested a review September 20, 2024 19:31
Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapplying approval.

@dmitriy-sobolev dmitriy-sobolev merged commit 27453fa into main Sep 20, 2024
22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/esimd-doc-reqs branch September 20, 2024 20:44
mmichel11 pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants