Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the directory structure for RFC documents #1878

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

akukanov
Copy link
Contributor

The proposed RFC structure and process generally match those recently accepted by oneTBB (see oneapi-src/oneTBB#1464) with some modifications, primarily just in the description. To see only the modifications, exclude the first commit when viewing the changes.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good. One small wording suggestion, and a suggestion for an "extension" category / directory.

rfcs/experimental/README.md Outdated Show resolved Hide resolved
rfcs/README.md Show resolved Hide resolved
Copy link
Contributor

@dcbenito dcbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested. Thanks.

rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/README.md Outdated Show resolved Hide resolved
rfcs/experimental/README.md Outdated Show resolved Hide resolved
rfcs/experimental/README.md Outdated Show resolved Hide resolved
rfcs/supported/README.md Outdated Show resolved Hide resolved
rfcs/template.md Outdated Show resolved Hide resolved
rfcs/template.md Outdated Show resolved Hide resolved
rfcs/template.md Outdated Show resolved Hide resolved
rfcs/template.md Outdated Show resolved Hide resolved
dcbenito
dcbenito previously approved these changes Sep 30, 2024
Copy link
Contributor

@dcbenito dcbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danhoeflinger
danhoeflinger previously approved these changes Oct 1, 2024
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RFC process looks clear and good to me. I have just left two small comments on wording / grammar.

rfcs/template.md Outdated Show resolved Hide resolved
rfcs/archived/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of minor suggestions. Overall, the documents look very good.

rfcs/README.md Show resolved Hide resolved
rfcs/README.md Show resolved Hide resolved
@akukanov akukanov dismissed stale reviews from danhoeflinger and dcbenito via d9613fe October 2, 2024 12:21
@akukanov akukanov merged commit c97070f into main Oct 4, 2024
22 checks passed
@akukanov akukanov deleted the rfc/add-rfc-folder-structure branch October 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants