Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include all necessary standard headers in utils_ranges.h #1896

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Include all necessary standard headers in utils_ranges.h #1896

merged 2 commits into from
Oct 11, 2024

Conversation

dmitriy-sobolev
Copy link
Contributor

The PR includes all the necessary standard headers while fixing the issue:

utils_ranges.h:81:23: error: 'uint8_t' in namespace 'std' does not name a type; did you mean 'wint_t'?

@dmitriy-sobolev
clang-format
da32407 
Signed-off-by: Dmitriy Sobolev <[email protected]>
MikeDvorskiy
MikeDvorskiy approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev dmitriy-sobolev changed the title Include all necessary std headers in utils_ranges.h Include all necessary standard headers in utils_ranges.h Oct 11, 2024
@dmitriy-sobolev dmitriy-sobolev merged commit 0d96301 into main Oct 11, 2024
22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/utils_ranges-headers branch October 11, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeDvorskiy MikeDvorskiy MikeDvorskiy approved these changes

@SergeyKopienko SergeyKopienko Awaiting requested review from SergeyKopienko

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitriy-sobolev @MikeDvorskiy