-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap linker flags on Windows for IntelLLLVM #2179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
FYI, similar PR was already verified and merged in umf: oneapi-src/unified-memory-framework#772
I can try and add an icx build in the CI, if you want...? (I'm doing such workflow for UMF at the moment) |
Ping, can we get this merged? I don't have merge access myself. |
@oneapi-src/unified-runtime-level-zero-write still need to approve this. |
dde91fa
to
af9bb26
Compare
@kbenzie can you approve the workflows? I rebased to see if the CI failures go away or if I will need to investigate. |
Ping @oneapi-src/unified-runtime-level-zero-write |
The pull request labeler job is expected to fail for PRs from people who aren't a memory of the UR traige team. If there are e2e failures that doesn't necessarily block merging as long as we can determine they are not related to these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for L0
just going to rebase to see if we can get a clean run of the e2e l0 job |
af9bb26
to
c0242e5
Compare
@aarongreig bump, should I look into the failures? I am not familiar with L0 and I don't expect runtime failures from this. This blocking some other future work for me. |
No, those failures are expected. |
Okay, Thank you. Lets get this merged then pretty please :). |
ping @callumfare @nrspruit @pbalcer |
@Maetveis Please resolve the conflicts and I'll make sure this gets merged soon |
c0242e5
to
9258490
Compare
9258490
to
d4195ad
Compare
Thanks! Done. |
The Intel C++ compiler requires linker flags to be wrapped, because CMake passes them through the compiler driver. Prefix linker options with `LINKER:`. CMake will transorm it to the appropriate flag for the compiler driver: (Nothing for MSVC or clang-cl, and /Qoption,link for icx), so this will work for other compilers and for earlier CMake versions too. Signed-off-by: Gergely Meszaros <[email protected]>
d4195ad
to
9339e37
Compare
Since #2100 was reverted and it had a CMake fix that was needed here (the source of the conflict previously) I restored this PR to how it was before conflict resolution. Ping @callumfare, please merge this ASAP. |
The Intel C++ compiler requires linker flags to be wrapped, because CMake passes them through the compiler driver.
Prefix linker options with
LINKER:
.CMake will transorm it to the appropriate flag for the compiler driver: (Nothing for MSVC or clang-cl, and /Qoption,link for icx), so this will work for other compilers and for earlier CMake versions too.
Note
Requires updating the fetched versions of UMF and Level Zero to versions that include the fix for the same problem. I tested locally with
-DUMF_TAG=e6ff45e1636bd172117bab6d9f4d00638113f592 -DUR_LEVEL_ZERO_LOADER_TAG=v1.18.1
.Fixes: #2178