Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify USMFree as a non-blocking operation. #2263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Explicitly specify USMFree as a non-blocking operation. #2263

wants to merge 1 commit into from

Conversation

aarongreig
Copy link
Contributor

Also update CL adapter to reflect this.

@github-actions github-actions bot added loader Loader related feature/bug specification Changes or additions to the specification labels Oct 29, 2024
@aarongreig aarongreig marked this pull request as ready for review October 30, 2024 11:23
@aarongreig aarongreig requested review from a team as code owners October 30, 2024 11:23
@EwanC EwanC mentioned this pull request Nov 1, 2024
Merged
callumfare
callumfare approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@callumfare callumfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs an intel/llvm PR since the adapter has changed

@aarongreig
Copy link
Contributor Author

LLVM PR: intel/llvm#16028

@aarongreig
Explicitly specify USMFree as a non-blocking operation.
b6c7e64 
Also update CL adapter to reflect this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumfare callumfare callumfare approved these changes

Assignees
No one assigned
Labels
loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarongreig @callumfare