Improvements to align CTS and Spec for Queue #2282
Open
+153
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martygrant
commented
Nov 4, 2024
martygrant
commented
- Add UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urQueueCreateWithNativeHandleTest
- Add tests for urQueueCreateWithNativeHandleTest for creating an owned/unowned native queue handle
- Removed urQueueGetInfoDeviceQueueTestWithInfoParam as it was redundant - already being checked with urQueueGetInfoTestWithInfoParam
- Added missing enum queries for urQueueGetInfoTestWithInfoParam
RossBrunton
reviewed
Nov 11, 2024
| reinterpret_cast<ur_bool_t *>(data.data()); | ||
| ASSERT_TRUE(returned_empty_queue); | ||
| break; | ||
| } | ||
| default: | ||
| break; |
There was a problem hiding this comment.
If we intend to check every info type (or at the very least, call attention to every info type), should we not return an error here rather than silently doing nothing?
There was a problem hiding this comment.
@RossBrunton I committed these changes before your comment here #2272 (comment) so I just reworked this PR to make the tests separate. I'll do the same for future PRs on the remaining CTS areas
aarongreig
reviewed
Nov 11, 2024
martygrant
force-pushed
the
martin/queue-cts-spec-gap
branch
5 times, most recently
from
fbe7927
to
ea4c70e
Compare
- Add UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urQueueCreateWithNativeHandleTest - Add tests for urQueueCreateWithNativeHandleTest for creating an owned/unowned native queue handle - Removed urQueueGetInfoDeviceQueueTestWithInfoParam as it was redundant - already being checked with urQueueGetInfoTestWithInfoParam - Added missing enum queries for urQueueGetInfoTestWithInfoParam
…switch statement in one test. Remove tests for owned/unowned native queue, as it is being handled in oneapi-src#2193.
martygrant
force-pushed
the
martin/queue-cts-spec-gap
branch
from
ea4c70e
to
c8089fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.