Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Clean up match files for conf. testing #2285

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

RossBrunton
Copy link
Contributor

Clean up the match files to hopefully make them more easily readable. As
we now use cts_exe.py, we don't need as many workarounds.

This changes the following:

  • Removes the "{{NONDETERMINISTIC}}" tag, which isn't needed any more.
  • Removes the notice about only being supported in cts_exe.py - all
    suites now require cts_exe.py.
  • Device names have been simplified down to a single wildcard -
    should make it easier to read them and copy between files if needed.
  • If all tests for a specific enum fail, it has been folded into a
    single wildcard.

@github-actions github-actions bot added the conformance Conformance test suite issues. label Nov 5, 2024
@martygrant
Copy link
Contributor

Last week we discussed our original goal of removing use of the match files, we plan to have a meeting soon to put a plan together. I think in the meantime it might be a good idea to have some documentation on how they work (not sure if there is any) given there have been some recent changes and with more proposed in this PR

@github-actions github-actions bot added the specification Changes or additions to the specification label Nov 13, 2024
@RossBrunton RossBrunton force-pushed the ross/confclean branch 2 times, most recently from 5e16015 to b1d2fe5 Compare November 13, 2024 14:43
@RossBrunton
Copy link
Contributor Author

Last week we discussed our original goal of removing use of the match files, we plan to have a meeting soon to put a plan together. I think in the meantime it might be a good idea to have some documentation on how they work (not sure if there is any) given there have been some recent changes and with more proposed in this PR

There's been a few updates to the documentation recently, is there anything you think is missing?

Clean up the match files to hopefully make them more easily readable. As
we now use cts_exe.py, we don't need as many workarounds.

This changes the following:
* Removes the "{{NONDETERMINISTIC}}" tag, which isn't needed any more.
* Removes the notice about only being supported in cts_exe.py - all
  suites now require cts_exe.py.
* Device names have been simplified down to a single wildcard -
  should make it easier to read them and copy between files if needed.
* If all tests for a specific enum fail, it has been folded into a
  single wildcard.
@RossBrunton RossBrunton marked this pull request as ready for review November 14, 2024 10:56
@RossBrunton RossBrunton requested review from a team as code owners November 14, 2024 10:56
@RossBrunton
Copy link
Contributor Author

Doesn't affect LLVM, merging without associated commit.

@RossBrunton RossBrunton merged commit 59cd752 into oneapi-src:main Nov 14, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance Conformance test suite issues. specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants