v8.2.0 release

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [8.2.0] - 2023-04-12
+
+### Changed:
+- Public: Updated underlying Onfido native SDKs versions:
+  - iOS 28.3.x (up from 28.1.x)
+  - Android 16.3.x (up from 16.1.x)
+
 ## [8.1.0] - 2023-03-06
 
 ### Changed:

README.md

@@ -153,6 +153,39 @@ android {
 ```
 </details>
 
+</br>
+
+
+NFC dependencies are not included in the SDK to avoid increasing the SDK size when the NFC feature is disabled. To use the NFC feature, you need to include the following dependencies (with the specified versions) in your build script:
+
+```gradle
+implementation "net.sf.scuba:scuba-sc-android:0.0.23"
+implementation "org.jmrtd:jmrtd:0.7.34"
+implementation "com.madgag.spongycastle:prov:1.58.0.0"
+```
+
+You also need to add the following Proguard rules to your `proguard-rules.pro` file:
+
+```
+-keep class org.jmrtd.** { *; }
+-keep class net.sf.scuba.** {*;}
+-keep class org.bouncycastle.** {*;}
+-keep class org.spongycastle.** {*;}
+-keep class org.ejbca.** {*;}
+
+-dontwarn kotlin.time.jdk8.DurationConversionsJDK8Kt
+-dontwarn org.ejbca.**
+-dontwarn org.bouncycastle.**
+-dontwarn org.spongycastle.**
+
+-dontwarn module-info
+-dontwarn org.jmrtd.**
+-dontwarn net.sf.scuba.**
+```
+
+
+</br>
+
 #### 4.3 Update your iOS configuration files
 
 Change `ios/Podfile` to use version 11:

SampleApp/App.js

@@ -70,8 +70,12 @@ export default class App extends Component {
   render() {
     return (
       <View style={styles.container}>
-        <Text style={styles.welcome}>{this.state.title}</Text>
-        <Text style={styles.instructions}>{this.state.subtitle}</Text>
+        <Text testID="firstName" style={styles.welcome}>
+          {this.state.title}
+        </Text>
+        <Text testID="lastName" style={styles.instructions}>
+          {this.state.subtitle}
+        </Text>
         <Button title="Launch" onPress={() => this.startSDK()} />
         {this.state.sdkFlowComplete ? (
           <Redirect to={`/finish/${this.state.status}/${this.state.message}`} />

SampleApp/android/app/build.gradle

@@ -226,7 +226,11 @@ dependencies {
     }
 
     androidTestImplementation('com.wix:detox:+') { transitive = true }
-    androidTestImplementation 'junit:junit:4.13.2'
+
+    // To use the JUnit Extension APIs
+    androidTestImplementation "androidx.test.ext:junit:1.1.5"
+    // Kotlin extensions for androidx.test.ext.junit
+    androidTestImplementation "androidx.test.ext:junit-ktx:1.1.5"
 }
 
 // Run this once to be able to run the application with BUCK

SampleApp/android/app/src/androidTest/java/com/sampleapp/DetoxTest.java

@@ -5,6 +5,7 @@
 import androidx.test.rule.ActivityTestRule;
 
 import com.wix.detox.Detox;
+import com.wix.detox.config.DetoxConfig;
 
 import org.junit.Rule;
 import org.junit.Test;
@@ -18,7 +19,12 @@ public class DetoxTest {
     public ActivityTestRule<MainActivity> mActivityRule = new ActivityTestRule<>(MainActivity.class, false, false);
 
     @Test
-    public void runDetoxTests() throws InterruptedException {
-        Detox.runTests(mActivityRule);
+    public void runDetoxTests() {
+        DetoxConfig detoxConfig = new DetoxConfig();
+        detoxConfig.idlePolicyConfig.masterTimeoutSec = 90;
+        detoxConfig.idlePolicyConfig.idleResourceTimeoutSec = 60;
+        detoxConfig.rnContextLoadTimeoutSec = (BuildConfig.DEBUG ? 180 : 60);
+
+        Detox.runTests(mActivityRule, detoxConfig);
     }
 }

SampleApp/android/app/src/main/AndroidManifest.xml

@@ -1,5 +1,6 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-  package="com.sampleapp">
+    xmlns:tools="http://schemas.android.com/tools"
+    package="com.sampleapp">
 
     <uses-permission android:name="android.permission.INTERNET" />
 
@@ -9,6 +10,8 @@
       android:icon="@mipmap/ic_launcher"
       android:roundIcon="@mipmap/ic_launcher_round"
       android:allowBackup="false"
+        android:exported="true"
+        android:networkSecurityConfig="@xml/network_security_config" tools:targetApi="24"
       android:theme="@style/AppTheme"
       >
       <activity
@@ -22,7 +25,7 @@
             <category android:name="android.intent.category.LAUNCHER" />
         </intent-filter>
       </activity>
-      <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
+      <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" android:exported="false" />
     </application>
 
 </manifest>

SampleApp/android/app/src/main/res/xml/network_security_config.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<network-security-config>
+    <domain-config cleartextTrafficPermitted="true">
+        <domain includeSubdomains="true">10.0.2.2</domain>
+        <domain includeSubdomains="true">localhost</domain>
+    </domain-config>
+</network-security-config>

SampleApp/android/build.gradle

@@ -53,4 +53,11 @@ allprojects {
         maven { url "$rootDir/../node_modules/detox/Detox-android" }
         maven { url "https://maven.google.com" }
     }
+    def REACT_NATIVE_VERSION = new File(['node', '--print',"JSON.parse(require('fs').readFileSync(require.resolve('react-native/package.json'), 'utf-8')).version"].execute(null, rootDir).text.trim())
+
+    configurations.all {
+        resolutionStrategy {
+            force "com.facebook.react:react-native:" + REACT_NATIVE_VERSION
+        }
+    }
 }

SampleApp/e2eAndroid/sampleAppFlow.spec.js

@@ -10,12 +10,8 @@ describe('Android Sample App flow', () => {
   });
 
   it('should complete the document and face flow on Android successfully', async () => {
-    await element(by.type('android.widget.EditText'))
-      .atIndex(0)
-      .typeText(textProps.firstName);
-    await element(by.type('android.widget.EditText'))
-      .atIndex(1)
-      .typeText(textProps.lastName);
+    await element(by.id('firstName')).atIndex(0).typeText(textProps.firstName);
+    await element(by.id('lastName')).atIndex(1).typeText(textProps.lastName);
     await element(by.text('Start SDK')).tap();
     await element(by.text('LAUNCH')).tap();
     await element(by.text('Start')).tap();

SampleApp/package.json

@@ -52,13 +52,13 @@
         "binaryPath": "android/app/build/outputs/apk/debug/app-debug.apk",
         "build": "cd android && ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug && cd ..",
         "type": "android.emulator",
-        "name": "Pixel_API_28_AOSP"
+        "name": "emulator"
       },
       "android.emu.release.sampleapp": {
         "binaryPath": "android/app/build/outputs/apk/release/app-release-bitrise-signed.apk",
         "build": "cd android && ./gradlew assembleRelease assembleAndroidTest -DtestBuildType=release && cd ..",
         "type": "android.emulator",
-        "name": "Pixel_API_28_AOSP"
+        "name": "emulator"
       }
     }
   }

android/build.gradle

@@ -13,7 +13,7 @@
 def DEFAULT_COMPILE_SDK_VERSION = 32
 def DEFAULT_MIN_SDK_VERSION = 21
 def DEFAULT_TARGET_SDK_VERSION = 31
-def NATIVE_ANDROID_SDK_VERSION = "16.1.+"
+def NATIVE_ANDROID_SDK_VERSION = "16.3.+"
 
 def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback

android/src/main/AndroidManifest.xml

@@ -8,6 +8,6 @@
 
         <meta-data
             android:name="onfido_integration_version"
-            android:value="8.1.1" />
+            android:value="8.2.0" />
     </application>
 </manifest>

android/src/test/java/com/onfido/reactnative/sdk/OnfidoSdkActivityEventListenerTest.java

@@ -151,8 +151,8 @@ public void shouldResolveWithDocumentSuccessfully() throws Exception {
         String docBackId = "docBackId123";
         String nfcMediaUUID = "docNfcMediaId123";
         Document documentMock = PowerMockito.mock(Document.class);
-        when(documentMock.getFront()).thenReturn(new DocumentSide(docFrontId, DocSide.FRONT, DocumentType.DRIVING_LICENCE));
-        when(documentMock.getBack()).thenReturn(new DocumentSide(docBackId, DocSide.BACK, DocumentType.DRIVING_LICENCE));
+        when(documentMock.getFront()).thenReturn(new DocumentSide(docFrontId, DocSide.FRONT, DocumentType.DRIVING_LICENCE, false));
+        when(documentMock.getBack()).thenReturn(new DocumentSide(docBackId, DocSide.BACK, DocumentType.DRIVING_LICENCE, false));
         when(documentMock.getNfcMediaUUID()).thenReturn(nfcMediaUUID);
         when(capturesMock.getDocument()).thenReturn(documentMock);
 

ios/Podfile

@@ -4,7 +4,7 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ
 platform :ios, '11.0'
 
 target 'OnfidoSdk' do
-  pod 'Onfido', '~> 28.1.0'
+  pod 'Onfido', '~> 28.3.0'
 
   config = use_native_modules!
   use_react_native!(

onfido-react-native-sdk.podspec

@@ -20,5 +20,5 @@ Pod::Spec.new do |s|
   s.requires_arc = true
 
   s.dependency "React"
-  s.dependency "Onfido", "~> 28.1.0"
+  s.dependency "Onfido", "~> 28.3.0"
 end

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@onfido/react-native-sdk",
   "title": "React Native Onfido Sdk",
-  "version": "8.1.1",
+  "version": "8.2.0",
   "description": "Onfido React Native SDK",
   "main": "index.ts",
   "scripts": {