-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Stable Cadence branch with master #2701
Sync Stable Cadence branch with master #2701
Conversation
Wrap host env errors with external errors
…/fix-storage-iteration
Fix storage iteration and error misclassification
Fix error on reference creation with invalid type
…ability-api-deprecations
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 9bdde37 Collapsed results for better readability
|
@turbolent Having a look. |
Update storage iteration value check and related tests
Codecov Report
@@ Coverage Diff @@
## feature/stable-cadence #2701 +/- ##
==========================================================
+ Coverage 78.87% 79.39% +0.51%
==========================================================
Files 341 336 -5
Lines 80168 80145 -23
==========================================================
+ Hits 63232 63628 +396
+ Misses 14641 14215 -426
- Partials 2295 2302 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Conflict resolution:
Mostly re-removed old linking-based capabiltity API.
Many storage iteration tests (
TestRuntimeStorageIteration
) are currently failing, because the value check used the linking API and needs to be updated. I commented it out temporarily.@SupunS could you maybe please also have a look at what needs to be done to restore the value check / error handling? 🙏
master
branchFiles changed
in the Github PR explorer