Avoid unnecessary static to sema type conversions for Type
#2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid unnecessary need for conversion to sema type
…ema type to get type ID
…to sema type to get type ID
turbolent
commented
Aug 25, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit bd3056f Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
- Coverage 79.20% 79.18% -0.02%
==========================================
Files 333 333
Lines 78561 78614 +53
==========================================
+ Hits 62221 62248 +27
- Misses 14038 14063 +25
- Partials 2302 2303 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dsainati1
approved these changes
Aug 28, 2023
SupunS
approved these changes
Aug 29, 2023
This was referenced Aug 29, 2023
turbolent
added
Storage Breaking Change
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2748
Description
interpreter.StaticTypecurrently does not expose a mechanism to get the type's ID.interpreter.TypeValueneeds to get a type ID in two places:identifierfieldHashInputfunction, e.g. used when the type value is used as a dictionary keyinterpreter.TypeValuecalculated the type ID by converting the static type to a sema type. This causes the whole program to be loaded, which is inefficient or even unavailable (e.g. during a state migration).Introduce
func StaticType.ID() TypeIDto allow getting the type ID for a static type without overhead, and remove the unnecessary conversions from static to sema type.cc @janezpodhostnik
masterbranchFiles changedin the Github PR explorer