Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreting for default events #2817

Merged
merged 19 commits into from
Nov 7, 2023
Merged

Interpreting for default events #2817

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3295bbb
emit default event
dsainati1 Sep 26, 2023
59210c1
emit events on destroy
dsainati1 Sep 26, 2023
b8954d4
fix attachment base values
dsainati1 Sep 26, 2023
e40c490
fix scoping across interpreters
dsainati1 Sep 26, 2023
24e6164
lint
dsainati1 Sep 26, 2023
85c12ac
Merge branch 'sainati/default-event-checking' of github.com:onflow/ca…
dsainati1 Sep 27, 2023
0d9bf8c
emit interface events as well
dsainati1 Sep 27, 2023
1e83b48
add test for same name interfaces
dsainati1 Sep 27, 2023
1d6cc42
Merge branch 'sainati/default-event-checking' of github.com:onflow/ca…
dsainati1 Oct 26, 2023
3ba46df
respond to review
dsainati1 Oct 31, 2023
ceebf15
Merge branch 'feature/remove-destructors' of github.com:onflow/cadenc…
dsainati1 Oct 31, 2023
366366d
use deterministic ordered function map
dsainati1 Oct 31, 2023
229a189
Update runtime/interpreter/interpreter.go
dsainati1 Nov 1, 2023
e0b9d03
respond to review
dsainati1 Nov 1, 2023
3cd0f5d
add comment
dsainati1 Nov 1, 2023
e5af208
rename variables
dsainati1 Nov 1, 2023
d8abdd4
proper lexical scoping and testing
dsainati1 Nov 1, 2023
920ea94
use new activation for default event param evaluation
dsainati1 Nov 2, 2023
89fbe55
style
dsainati1 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/environment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,7 @@ func (e *interpreterEnvironment) newCompositeValueFunctionsHandler() interpreter
inter *interpreter.Interpreter,
locationRange interpreter.LocationRange,
compositeValue *interpreter.CompositeValue,
) map[string]interpreter.FunctionValue {
) *interpreter.FunctionOrderedMap {

handler := e.compositeValueFunctionsHandlers[compositeValue.TypeID()]
if handler == nil {
Expand Down
Loading
Loading