Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent migration tests from using out-of-sync data #3597

Merged
merged 1 commit into from
Oct 15, 2024

Commits on Oct 2, 2024

  1. Prevent migration tests from using out-of-sync data

    Currently, some migration tests reuse storage for migration.
    It can lead to tests failing when the storage cache gets
    out of sync with underlying storage.
    
    For example:
    1. Use storage 1 to store valueA in public domain directly.
    2. Use storage 2 to store valueB in public domain via
       ExecuteTransaction().
    3. Reuse storage 1 for migration.  Here, migration
       only sees valueA from cache instead of both values.
    
    This commit prevents out-of-sync issues by creating new
    runtime.Storage for migrations instead of reusing old storage.
    fxamacker committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    88c3cf0 View commit details
    Browse the repository at this point in the history