Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve location of imported values #3634

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

turbolent
Copy link
Member

Description

Follow-up to #3619

If we are translating imports of programs, e.g. import Crypto to the chain-specific address, we also must perform the same location translation when importing values.

This became evident while working on onflow/flow-go#6571, and specifically while updating the Emulator, which has a test case fro importing Crypto.KeyList. I've added a generic test case here, and will add a test case for Crypto.KeyList to flow-go in onflow/flow-go#6571.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 21, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit d96a90d
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit 1662018 into master Oct 21, 2024
10 of 12 checks passed
@turbolent turbolent deleted the bastian/resolve-value-import-location branch October 21, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants