Resolve location of imported values #3634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #3619
If we are translating imports of programs, e.g.
import Crypto
to the chain-specific address, we also must perform the same location translation when importing values.This became evident while working on onflow/flow-go#6571, and specifically while updating the Emulator, which has a test case fro importing
Crypto.KeyList
. I've added a generic test case here, and will add a test case forCrypto.KeyList
to flow-go in onflow/flow-go#6571.master
branchFiles changed
in the Github PR explorer