Refactor storage domains to prevent import cycles and simplify maintenance #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, various storage domains are defined in different packages, such as: - common - runtime - stdlib This commit moves storage domains from different packages to a single place: common/storagedomain.go. This change will help us avoid import cycles when using domains across different packages.
Currently, we use domain string to get StorageMap. Even though we use pre-defined domain strings, this can still be error-prone. This commit modifies GetStorageMap() to use common.StorageDomain instead of string.
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit a56e521 Collapsed results for better readability
|
13 tasks
fxamacker
changed the title
6 tasks
|
I didn't see additional review was requested. Although this PR was merged, please feel free to share additional feedback and I will take a look. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3672
Updates #3584
Description
Currently, various storage domains are defined in different packages, such as:
Also, domain string is used to get
StorageMap. Although we use pre-defined domain strings, this can still be error-prone.Solution
This PR moves storage domains from different packages to a single place:
While at it, this PR also modifies
GetStorageMap()to usecommon.StorageDomaininstead of string.Context
This refactoring is needed for upcoming storage optimization to replace domain name string with domain integer in account storage map. Without this PR, we would run into import cycles.
masterbranchFiles changedin the Github PR explorer